Retry updater container creation on SMB mount failure#598
Closed
jeffwidman wants to merge 1 commit intomainfrom
Closed
Retry updater container creation on SMB mount failure#598jeffwidman wants to merge 1 commit intomainfrom
jeffwidman wants to merge 1 commit intomainfrom
Conversation
The CIFS volume mount occurs during container creation, and the SMB service inside the storage container may not be fully ready even though port 445 is listening. Instead of relying on a sleep after port detection, retry the container creation up to 3 times with a 2-second backoff when a mount error occurs. Also removes the 1-second sleep in waitForPort that was a workaround for the same issue.
Member
Author
|
A flaky CI test popped up on another PR, so I asked copilot to make this a little more robust... |
Member
Author
|
It looks like https://github.com/dependabot/cli/actions/runs/22881413409/job/66384821890?pr=598 may indicate this path isn't worth pursuing |
Member
Author
|
For now i'm going to set this aside, it's not worth yak-shaving unless/until it becomes mroe frequent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
smb-mountscript test intermittently fails in CI with:The CIFS volume mount happens during
ContainerCreate, and the SMB service inside the storage container may not be fully ready even though port 445 is listening. The previous workaround was a 1-second sleep after port detection, which wasn't always sufficient.Fix
cli.ContainerCreatewhen a mount error is detected. This directly addresses the failure point rather than trying to predict when SMB is ready.waitForPortthat was a workaround for the same issue — it's no longer needed since retries handle the race condition.Testing
The fix targets the flaky
TestDependabot/smb-mounttest. CI will validate it passes.